Add check for vnet location for Azure Spring Cloud#2255
Merged
yungezz merged 4 commits intoAzure:masterfrom Sep 2, 2020
VSChina:jieshe/vnet-location
Merged
Add check for vnet location for Azure Spring Cloud#2255yungezz merged 4 commits intoAzure:masterfrom VSChina:jieshe/vnet-location
yungezz merged 4 commits intoAzure:masterfrom
VSChina:jieshe/vnet-location
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
yungezz
reviewed
Sep 1, 2020
| raise CLIError('--app-subnet and --service-runtime-subnet should not be the same.') | ||
|
|
||
| vnet_obj = _get_vnet(cmd, vnet_id) | ||
| instance_location = namespace.location |
Member
There was a problem hiding this comment.
will there be format difference? like west us vs westus. :)
yungezz
approved these changes
Sep 2, 2020
Member
|
pls resolve conflict, then good to go. |
# Conflicts: # src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_validator.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For VNet Injection instance, Azure Spring Cloud instance should be in the same location as the target VNet.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.